The short version:
1) M19 is uploaded.
2) Please delete your existing [Lackey Folder]/plugins/magic/sets/setimages folder so that new images can be downloaded.
3) If you have any saved decks including double-faced cards from Innistrad, Dark Ascension, or possibly origins, you will have to manually re-add those particular cards.
Explanations/elaborations:
1) M19 is pretty bare-bones. Literally the only script is the one to transform Bolas, and I've not yet updated the formats. (I also haven't done Battlebond yet.)
2) Scryfall took over Magicccards.info. Requests for MCI image URLs now redirect to Scryfall, but Lackey isn't smart enough to get the image it's redirected to, so they no longer work. I went ahead and changed the entire plugin over to Scryfall's images. Unfortunately, they're a different size than what we've been using. If you have existing image files and download new ones now, things will look weird in Lackey. Sorry, I know it's inconvenient. Also, I've only changed over actual Magic cards for now?tokens will be broken until I figure out their new image format.
Addendum: I didn't realize that Magiccards.info stored a lot of older sets in some sort of nonstandard order, making the images not come up for the right cards. Most cards that have multiple art in the same set don't even load anything. I'll see if I can figure this out tomorrow. Modern sets should work?I'll keep checking to make sure I haven't missed anything. Should be mostly fixed?see post below.
3) The plugin stored Innistrad and Dark Ascension DFC as one card, with the night side on the back. This makes physical sense, but doesn't let you manifest DFC. Sets from Shadows onward instead give you a script to spawn a token-like back face from the front face, and Origins, confusingly, did both. I've gone back and standardized it so now they all work the new way.
Sorry for my absence. Things have been hectic for me. As my life settles back down, I intend to continue getting the plugin back into proper up-to-date shape.
Just an update: I am working on this today. With any luck, I can have the older sets working again later today.
I've gone back and fixed (almost) all the sets so they will now correctly download images from Scryfall. Out of what was already in Lackey, I should now have correct images for everything EXCEPT:
- "Special" cards (like World Champion and the Hydra deck)
- Schemes
- Planes and Phenomena
- Vanguard avatars
- Reprint-only sets (like Modern Masters and Duel Decks)
- All tokens :' (
My next step is to... fix the rest of those things, as well as add newer sets:
- Battlebond
- Commander 2018
- Archenemy: Bolas (at least the schemes)
- Global Series
And I should update pack definitions too.
I may not be able to get back to this for a week or so, but hopefully this is enough to make things mostly functional for the time being.
If you encounter missing or incorrect images with cards other than what I listed above, please post about it in this thread.
Is there any way to revert this update to the previous one?
I think this plugin is great and I want to keep playing it, but with this update I find it awful. The size of the new images have completely ruined it,and the new tabletop is, in my opinion, atrocious.
Thank you for taking the time to work on this plugin.
New tabletop? I'm not aware of a new tabletop. Did one of your preferences get changed somehow? Is anyone else seeing a new tabletop image?
May I ask what the problem is with the image size? Are they taking too long to download? If they're doing that annoying thing where they pop out of the card-viewing pane, that's fixable in your preferences. Preferences > Appearance > Card appearance preferences > Make card viewer image pop out on mouse over? [uncheck]
As long as that's set, I don't really see much of any difference on my end while using Lackey. Let me know if I'm missing something.
man this new card image on the lackey interface is HUGE. should be about half the size
Can you please be more specific? Do you just mean that the images are too large in file size, or do they actually appear too large in the interface? If they look too big in Lackey, can you post a screenshot of what's going on? Is on the table, in the view pane, or both?
The image files themselves are larger, but they should look basically the same within Lackey. If they're not, something is up and I need to figure out what. If you turn a card on the table face down, is the back the same size?
This is the only size Scryfall makes the images available in cropped mode. And the only smaller size at all is quite small, smaller than the plugin used previously. I don't really have a way to fetch a size like I used to use, unless I save every single image from Scryfall and save a resized version to my server, then serve them all from there, and... I really, really don't want to do that.
Hate to pile on, but I just downloaded the latest update and when I went to load a deck, just under half my cards were gone. Whole sets seem to be gone, like everything from Theros or BNG...
Oy vey, when it rains it pours.
MunchKING, sorry to hear that. Do you mean that the images don't work / don't load, or are the cards themselves missing? Like do you open what was a 60-card deck and find it's actually fewer cards now?
P.S. And while you're here, you're not seeing a new table image, are you? I'm not even sure I CAN set a new one from the plugin, certainly not without a pluginpreferences file, which it doesn't include, but you never know...
Well the table was different, in that the card image section was taking up like a 3rd of the screen, but that was easily resized to something more useful.
And yeah I opened up a 100 card commander deck and it only loaded 55. For the others it said "Error loading deck: Unable to load card "X" from set "Y""
Like, "Unable to load card "Dragonsoul Knight" from set "mm2"." for example.
I tried checking for the card names in the deck editor in case the set code had just been renamed or something, but I couldn't find any of them.
THANK YOU! Specific examples help so much. Turns out I made an error in the updatelist: I'd left out a file declaration, so it wasn't downloading those sets. I just uploaded a new version. Can you update your plugin and see if the cards show up now?
I've also gone in and fixed images for?I believe?every card already in Lackey, except for tokens. I even noticed a handful of planes and schemes were missing, so I put those in too. Obviously that's a hard thing to test exhaustively, so I appreciate a heads up if you find more cards missing entirely, with missing images, or with incorrect images.
OK, the decks I tested had all their cards. I of course didn't check literally all the cards, but the problem SEEMS solved. Thanks!
Sounds good. I just noticed that aftermath cards don't fetch their images. I'll fix that in the next update.
Everything is working exactly as expected for me (per known bugs above). My screen size makes the new full resolution "pop out" size untenable so I disabled that option in Preferences. The only problem is that I'm now relying on "Make card viewer image stretch to allotted space" and the interpolation of the text on the larger images is really... unfortunate. TBC: At full size the new images look great. I've included a few screenshots below.
https://imgur.com/a/FuAHmT7 (https://imgur.com/a/FuAHmT7)
I'm guessing this is probably beyond the scope of the magic plugin and more an issue with the application itself, but figured I'd document the issue. Thanks for taking the reigns on maintaining the plugin. Cheers.
Oof. Yeah, it seems worse on some than on others. Unfortunately I have no control over the interpolation method used within Lackey, nor over the size provided by Scryfall (without saving and serving thousands of images myself). I've always used the "card stretch" feature, but the interpolation is definitely more noticeable now. I don't know when Trevor will next get a chance to do any work on Lackey, but maybe I could post about it in the bug section since there's none specifically for feature requests.
Thank you all, likewise, for your patience and your feedback.
https://i.imgur.com/DqNQnls.png
This is the tabletop that was added after i got the latest update, I didn't mess with any preferences beforehand either.
Otherwise everything is working great for the most part
thanks again for managing the plugin
Tbrox1234 there's a way to fix that particular tabletop. I ran into it a couple times a couple years ago with the Pokemon TCG plugin. What you need to do is hit the "+" button in the top right corner, and then from there you should see an option in the top bar that pops out called "Tilt". Click the "0" button next to it and your tabletop should return to normal
That did the trick, thanks a bunch.
sorry for thinking it was the update, happened after so i just assumed
I'm glad that worked out. I don't know how or why Lackey just forgets some of its preferences like that, but it certainly can be jarring.
I just uploaded another update. Battlebond, Commander 2018, Global Series: Jiang Yanggu & Mu Yanling, and the schemes from Archenemy: Nicol Bolas should all be there. They (and M19 now, as well) have some basic scripts: ETB tapped, planeswalker loyalty, and flying.
The big thing left at this point is tokens. Tokens have been handled all sorts of different ways over the course of the plugin, saved with their names in all different formats, and I want to take the time to sit down and figure out a better system for them. Once that's done and the tokens themselves work, I'll update these latest sets with their convenient token-spawning scripts.
Falling Star's Card image is Dwarven Song for some reason
Huh, the zero-cost kobolds were grouped by themselves instead of with red cards, and it threw off the order of everything. Fixed now.
Note that because I'm fixing this on the same date as the previous update, your plugin won't automatically download the new file, but it should if you tell it to update from the URL.
Huh... It downloaded a new update today, but that wasn't fixed. ???
That... is weird. I had it fixed on my copy...
The good news is that the headaches of piecemeal updating these inherited card lists by hand should be over soon. I'm working on a set of scripts to scrape, format, and write any and all sets in one go, which means 1) everything will be consistently templated across the plugin, for a change and 2) I can keep the whole plugin updated to Oracle errata as it comes out (not that people read the text cards much I imagine, but it will still be nice). Since they also pull the image file field directly from Scryfall, it will also mean I can't make manual mistakes like these anymore!
They're already working enough that I used them to generate the data for the sets I recently added. With a bit more tweaking (mostly adding support for more card scripts), they should be ready for the rest of Magic.
Hello, I have noticed another thing. I can't download images for Hanweir the writhing, hilling grasp and Brisela voice of night for the EMN.
Thanks.
And for others cards, same problem. I make a listing if it interests you...
Thank you for the offer. Usually I would love examples, but right now I'm working on a big update that should fix a lot of things, so I don't think I want to try and fix individual issues for the next few days.
I'll post here when it's up, and after that I would appreciate hearing about any more errors that crop up.
Thank you all for your patience.
http://www.lackeyccg.com/forum/index.php?topic=12684.msg30026#msg30026 (http://www.lackeyccg.com/forum/index.php?topic=12684.msg30026#msg30026)
Things should work now, and I'm happy to hear about things that don't.
For me black cards from the portal set seem to give me the wrong cards. Kings Assassin is showing the card for Muck rats. Assassin's Blade is showing Bog Raiders.
Quote from: The MunchKING on September 15, 2018, 07:16:06 PM
For me black cards from the portal set seem to give me the wrong cards. Kings Assassin is showing the card for Muck rats. Assassin's Blade is showing Bog Raiders.
They load the correct images for me. Are you sure your plugin is updated?
*tries it*
*glares at Lackey*
Apparently not.
Sorry, it didn't tell me there was an update.
And now it's missing a bunch of cards again.
"Error loading deck: Unable to load card "Ameboid Changeling" from set lorwyn"
same idea for shape sharer, skeletal Changeling, Carin wanderer, Levitation, Corrosive Mentor, Distant Melody, etc.
Okay that's weird, I could swear Lorwyn and Shadowmoor were working fine but they're just... not there. I'll figure it out.
I found the problem. The Lackey plugin has, over its history, added sets with all kinds of name formats. These days I store everything internally with its official three-letter abbreviation, and have a lookup table to provide the nonstandard names, so that saved decks are able to find their cards. Turns out I missed some! Should be fixed now.
Also, the embalmed token of Temmet was showing up as a regular card rather than a token. That's fixed now too.
Alright... Still missing Levetation from 2010, though it seems most of the rest of 2010 is there and all of 10e...
Try it now? (It won't automatically update, since the listed update date is the same.)
Got all those, now it's lost Shore Crasher from dtk, Qarsi Deciever from dtk, all the secret bases except order of the widget from Unstable, and the Human Ascendant from sok.
Quote from: The MunchKING on September 17, 2018, 01:07:52 PM
Got all those, now it's lost Shore Crasher from dtk, Qarsi Deciever from dtk, all the secret bases except order of the widget from Unstable, and the Human Ascendant from sok.
Looking back, it appears Lackey previously had Shorecrasher Elemental misnamed as Shore Crasher, and Qarsi Deceiver as Qarsi Deciever. I don't think backwards compatibility is worth maintaining actual name errors.
Good catch on the Secret Base. I'll fix that.
I saved the flip cards as {Side One} // {Side Two}, like split card titles, not realizing the plugin had them stored previously as just their right-side-up name. I will fix that so it's backwards compatible.
Fixed flip cards, and added in ALL the Unstable variants, even the mechanically identical ones.
You owe this to yourself, right now: go into deck editor, type in Extremely Slow Zombie, and then mouse over the different version to see it animated. : D
Now it appears to work, thanks.